Add invalid-JSON test for append-run-log - #491
Closed
shaurya703 wants to merge 1 commit into
Closed
Conversation
- Invalid second arg exits 1 and prints a Usage message mentioning valid JSON - Valid minimal JSON entry appends to a temp log without throwing - Run with: node --test scripts/append-run-log.test.mjs Fixes cobusgreyling#481
Owner
|
Thanks for the contribution! Closing as a duplicate of the green PRs that just merged (same tests from the Wave 6 good-first-issue batch):
Your effort still matters — grab another |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
Adds
scripts/append-run-log.test.mjslocking in the behaviour from #474:loop-run-log.mdwithout throwing (temp file created and cleaned up inside the test — the real run log is untouched)Run with:
Results: 2 tests, 2 pass, 0 fail.